Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tar): use sync codepath on sync methods #791

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

flensrocker
Copy link
Contributor

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Fixes #788

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #791 (5c314d9) into master (75d1cf8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #791   +/-   ##
=======================================
  Coverage   74.71%   74.71%           
=======================================
  Files          72       72           
  Lines        8468     8468           
=======================================
  Hits         6327     6327           
  Misses       2141     2141           
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Tar/TarInputStream.cs 63.20% <100.00%> (ø)
src/ICSharpCode.SharpZipLib/Tar/TarOutputStream.cs 67.83% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@piksel
Copy link
Member

piksel commented Oct 20, 2022

Ehm, yeah, that was much more obvious than I thought. Probably should have started looking there... 😁

@piksel piksel merged commit 23becfd into icsharpcode:master Oct 20, 2022
@flensrocker
Copy link
Contributor Author

I looked at those lines more than once... and didn't see it.

I started to use enums instead of booleans for such switches because they are more readable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TarInputStream does not run synchronously when used non-async
2 participants